Fix: rebuild missing dataset files#1417
Merged
Merged
Conversation
…files + corrected a bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Added a dataset_id parameter to rebuild_missing_dataset_files to rebuild a specific dataset.
Corrected a problem where the last datasets were not processed if the count was not a multiple of 5.
From our AI friend
This pull request adds support for processing a specific GTFS dataset by its stable ID in the dataset files rebuilding workflow. The changes update both the main logic and documentation, and introduce new tests to verify this functionality.
Feature: Process a specific dataset by ID
dataset_idparameter to the payload for the dataset files rebuild function, allowing the process to target a single dataset and supersede theafter_dateandlatest_onlyparameters. The documentation inREADME.mdwas updated to explain usage and behavior. [1] [2] [3]rebuild_missing_dataset_files.pyto accept and forward thedataset_idparameter, and changed the dataset selection logic to query by stable ID when provided. [1] [2] [3]dataset_idparameter for clarity.Testing improvements
test_rebuild_missing_dataset_files.pyto verify that the handler and main function correctly process thedataset_idparameter, including tests for payload forwarding and message publishing behavior when a specific dataset is targeted. [1] [2] [3]These changes make the dataset files rebuilding workflow more flexible and testable, allowing targeted processing for debugging or special cases.
the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything